You think you're doing code reviews, but you're probably just glancing at the code. There are levels to this game. Most developers are stuck at level 2. A good code review is the single best way to improve code quality, share knowledge, and build a better team. A bad one is a waste of time that breeds resentment. Which level are you on? → Level 1: The "LGTM" Review - You give the code a quick scan, see nothing obviously broken, and approve it with "Looks Good To Me." - This is a rubber stamp, not a review. It provides a false sense of security. → Level 2: The Style Sheriff - You focus on formatting, naming conventions, and other cosmetic issues. "Please add a space here." "This variable should be camelCase." - This is important for consistency, but linters and formatters can automate it. You're a human, do what a machine can't. → Level 3: The Bug Hunter - You're actively looking for logical errors, off-by-one errors, null pointer exceptions, and other potential bugs. - You're asking: "What happens if this input is null?" "Is there a race condition here?" - This is where reviews start to add real value. → Level 4: The Maintainability Master - You're thinking about the future. Is this code easy to understand? Is it well-tested? Can a new developer figure this out? - You're suggesting better variable names, clearer comments, and breaking down complex functions. You're asking "why" this way and not another. → Level 5: The Architectural Arbiter - You're looking at the big picture. Does this change fit with the overall architecture of the system? Does it introduce a new dependency we don't want? Is it scalable? - You're protecting the long-term health of the codebase. → Level 6: The Knowledge Sharer - You use the code review as a teaching opportunity. You explain *why* you're making a suggestion, linking to documentation, articles, or best practices. - You're not just improving the code; you're improving the developer who wrote it. → Level 7: The Positive Reinforcer - You not only point out what's wrong but also what's right. "This is a really clever solution." "Great use of the Strategy pattern here." - Positive feedback is a powerful motivator and makes developers more receptive to criticism. What level are you at? What's the best (or worst) code review comment you've ever received? Let's share stories in the comments. Subscribe to our newsletter [ https://bit.ly/4on6wQt ] to stay up to date and get 3 months free IntelliJ licence. #systemdesign #coding #interviewtips
A great code reviewer helps other teammates learn and grow their skills by providing constructive feedback and explaining the WHY behind the comments. I've seen many people say, "Do X, Y, Z", but haven't explained why we need that stuff... Nelson Djalo
Nelson Djalo Brilliant breakdown of what makes a meaningful code review. The shift from “bug hunting” to “knowledge sharing” and “positive reinforcement” is what transforms teams from good to great. This should be a checklist for every dev team.