Ameer Hamza’s Post

Career | 👁️ Code Review Culture — What Senior Devs Actually Review Junior devs review for functionality. Senior devs review for something else entirely. I used to think a "Good PR" was just code that worked and passed the build. I was wrong. Now, when I review code, I’m not looking at whether it runs—I’m looking at how it lives. If we have a linter, I don’t care about your tabs or spaces. That’s the machine's job. My job is to protect the future of the codebase. Here is what I actually look for in a PR: 🏗️ Architecture over Implementation Does this fit our existing patterns, or are we accidentally introducing a "special case" that will become a legacy nightmare in three months? 🔗 Decoupling over Speed Is this class doing too much? If I see tight coupling or a "God Object" being born, I flag it. Code should be modular, not a tangled web. 🧪 The Testability Litmus Test If you have to mock five different dependencies just to write one unit test, the code is too complex. Simple code is easy to test. 📖 The "New Hire" Naming Test Can a developer who joined yesterday understand what this function does without reading the logic? If the name doesn't tell the story, the code is a riddle. ⚠️ The "What If" Scenarios Functional code handles the "Happy Path." Senior code handles the empty arrays, the nil optionals, and the inevitable network failures. The most impactful PR comment I ever received was: "This works, but in 6 months, no one will know why." Remember: Code is read 10x more than it is written. We aren't writing for the compiler; we are writing for the person who has to fix this at 3 AM a year from now. Senior Devs: What is the one thing you always look for that juniors often miss? Junior Devs: What’s the most helpful PR feedback you’ve ever received? 👇 Let’s discuss in the comments. #CodeReview #SoftwareEngineering #CleanCode #SeniorDeveloper #ProgrammingTips #TechLeadership #WebDevelopment #SwiftUI

  • No alternative text description for this image

To view or add a comment, sign in

Explore content categories